Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disttask: add on subtask finished interface for scheduler #43155

Merged
merged 5 commits into from
Apr 20, 2023
Merged

disttask: add on subtask finished interface for scheduler #43155

merged 5 commits into from
Apr 20, 2023

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Apr 18, 2023

What problem does this PR solve?

Issue Number: close #43153

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 18, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Benjamin2037
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 18, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Apr 18, 2023

/retest

1 similar comment
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Apr 18, 2023

/retest

Benjamin2037
Benjamin2037 approved these changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 19, 2023
zimulala
zimulala reviewed Apr 19, 2023
View reviewed changes
disttask/framework/scheduler/scheduler.go Outdated
@@ -162,6 +162,15 @@ func (s *InternalSchedulerImpl) Run(ctx context.Context, task *proto.Task) error
}
break
}
if err := scheduler.OnSubtaskFinished(runCtx, subtask.Meta); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we put this logic before line157, then we can remove line167-173

@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/test all

zimulala
zimulala approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 19, 2023
@zimulala
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f434742

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 19, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Apr 19, 2023

/retest

4 similar comments
@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/retest

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Apr 19, 2023

/retest

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Apr 19, 2023

/retest

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Apr 19, 2023

/merge

1 similar comment
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Apr 20, 2023

/merge

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Apr 20, 2023

/retest

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 20, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Apr 20, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2d8902c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 20, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Apr 20, 2023

/retest

@ti-chi-bot ti-chi-bot merged commit bd96034 into pingcap:master Apr 20, 2023
@GMHDBJD GMHDBJD added type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Apr 20, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Apr 20, 2023

/run-cherrypick

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 20, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #43251.

ti-chi-bot added a commit that referenced this pull request Apr 20, 2023
@ti-chi-bot
disttask: add on subtask finished interface for scheduler (#43155) (#…
d3dce91 
…43251)

close #43153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add OnSubtaskFinished interface
5 participants
@GMHDBJD @ti-chi-bot @hawkingrei @zimulala @Benjamin2037