Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner, executor: indexMerge support partition table with limit embedded #43173

Merged
merged 10 commits into from
Apr 20, 2023
Merged

planner, executor: indexMerge support partition table with limit embedded #43173

merged 10 commits into from
Apr 20, 2023

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #43158, close #43160, ref #41028

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
use real tikv env to run executor_test.TestOrderByWithLimit and passed.
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 19, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. labels Apr 19, 2023
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 19, 2023
@Defined2014 Defined2014 changed the title Index merge partition planner, executor: indexMerge support partition table with limit embedded Apr 19, 2023
@Defined2014
Copy link
Contributor Author

/retest

1 similar comment
@Defined2014
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 20, 2023
@Defined2014
Copy link
Contributor Author

/retest

XuHuaiyu
XuHuaiyu reviewed Apr 20, 2023
View reviewed changes
executor/index_merge_reader.go Outdated
@@ -663,10 +703,26 @@ func (w *partialTableWorker) extractTaskHandles(ctx context.Context, chk *chunk.
memUsage += memDelta
w.memTracker.Consume(memDelta)
for i := 0; i < chk.NumRows(); i++ {
handle, err := handleCols.BuildHandle(chk.GetRow(i))
w.scannedKeys++
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this line to line 708?

executor/index_merge_reader.go
pushedLimit *plannercore.PushedDownLimit
}

func (w *partialTableWorker) needPartitionHandle() bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment for this function.

executor/index_merge_reader.go Show resolved Hide resolved
planner/core/casetest/testdata/plan_suite_out.json Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Apr 20, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 20, 2023
@Defined2014
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0e510e6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 20, 2023
@Defined2014
Copy link
Contributor Author

/retest

2 similar comments
@Defined2014
Copy link
Contributor Author

/retest

@Defined2014
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot merged commit 658e7b8 into pingcap:master Apr 20, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 20, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #43261.

@Defined2014 Defined2014 deleted the indexMergePartition branch April 20, 2023 13:48
ti-chi-bot added a commit that referenced this pull request Apr 21, 2023
@ti-chi-bot
planner, executor: indexMerge support partition table with limit embe…
c65e6ac 
…dded (#43173) (#43261)

ref #41028, close #43158, close #43160
@XuHuaiyu XuHuaiyu mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@winoros winoros winoros approved these changes

@guo-shaoge guo-shaoge Awaiting requested review from guo-shaoge

Assignees
No one assigned
Labels
needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
4 participants
@Defined2014 @ti-chi-bot @winoros @XuHuaiyu