-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backup: check the store state by last heartbeat (#43099) #43216
backup: check the store state by last heartbeat (#43099) #43216
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leavrth, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test unit-test |
@YuJuncen: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@YuJuncen: No presubmit jobs available for pingcap/tidb@release-6.1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test unit-test |
@YuJuncen: No presubmit jobs available for pingcap/tidb@release-6.1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #43099
What problem does this PR solve?
Issue Number: close #42973
Problem Summary:
The current implementation cannot detect whether a store is down. So it keeps retry sending request to an offline store.
What is changed and how it works?
This PR checks the
LastHeartbeatTS
of the store and give up to request the store once the gap is greater than 20s (also defined in the PD package.)Check List
Tests
Backup over a cluster with one node down, finished in reasonable time.
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.