Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: recalculate as-of ts of staleread when plan is cached (#43204) #43257

Merged
merged 2 commits into from
Apr 25, 2023
Merged

planner: recalculate as-of ts of staleread when plan is cached (#43204) #43257

merged 2 commits into from
Apr 25, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #43204

What problem does this PR solve?

Issue Number: close #43044

Problem Summary:

What is changed and how it works?

Recalculate the snapshot ts for staleread when it's provided by as of statement.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the bug that prepared staleread cannot read following changes.

you06 added 2 commits April 20, 2023 12:58
@you06 @ti-chi-bot
recalculate staleread ts when statement is cached
b8f1bed 
Signed-off-by: you06 <you1474600@gmail.com>

lint

Signed-off-by: you06 <you1474600@gmail.com>

add more test cases

Signed-off-by: you06 <you1474600@gmail.com>

add comment

Signed-off-by: you06 <you1474600@gmail.com>

add comment

Signed-off-by: you06 <you1474600@gmail.com>
@you06 @ti-chi-bot
stable resultset
cd8fa48 
Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 20, 2023 •
edited by ti-chi-bot bot
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 20, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Apr 20, 2023
@you06 you06 requested a review from qw4990 April 21, 2023 05:42
@you06
Copy link
Contributor

you06 commented Apr 24, 2023

/retest

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Apr 24, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 24, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 24, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 25, 2023
@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 25, 2023

This pull request has been accepted and is ready to merge.

Commit hash: cd8fa48

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2023
@you06
Copy link
Contributor

you06 commented Apr 25, 2023

/retest

3 similar comments
@you06
Copy link
Contributor

you06 commented Apr 25, 2023

/retest

@you06
Copy link
Contributor

you06 commented Apr 25, 2023

/retest

@you06
Copy link
Contributor

you06 commented Apr 25, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit edd31b1 into pingcap:release-7.1 Apr 25, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels May 18, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 18, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot May 18, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels May 31, 2023
@qiancai qiancai mentioned this pull request Jun 26, 2023
Merged
16 tasks
@you06 you06 mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

Assignees

@you06 you06

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @you06 @cfzjywxk @qw4990 @VelocityLight