Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owner: add setting/getting the owner value info #43353

Merged
merged 3 commits into from
May 4, 2023
Merged

owner: add setting/getting the owner value info #43353

merged 3 commits into from
May 4, 2023

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Apr 24, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #43352

Problem Summary:

What is changed and how it works?

Add SetOwnerOpValue for Manager.
Add GetOwnerOpValue to the file of owner.go.
GetOwnerInfo is not quite the right, rename it GetOwnerKey.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 24, 2023
@pingcap pingcap deleted a comment from ti-chi-bot bot Apr 24, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Apr 24, 2023
@pingcap pingcap deleted a comment from ti-chi-bot Apr 24, 2023
@pingcap pingcap deleted a comment from ti-chi-bot bot Apr 24, 2023
@pingcap pingcap deleted a comment from ti-chi-bot Apr 24, 2023
@zimulala zimulala requested a review from tangenta April 24, 2023 10:16
tangenta
tangenta reviewed Apr 25, 2023
View reviewed changes
owner/manager.go Show resolved Hide resolved
owner/manager.go Outdated Show resolved Hide resolved
@pingcap pingcap deleted a comment from ti-chi-bot bot Apr 26, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 26, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 26, 2023
hawkingrei
hawkingrei reviewed Apr 27, 2023
View reviewed changes
owner/manager.go

// List operation of types.
const (
OpNone OpType = 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use iota here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a little bit clearer to just assign it

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 27, 2023
@zimulala
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 28, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 890408a

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 28, 2023
@zimulala
Copy link
Contributor Author

/test check-dev2

@zimulala
Copy link
Contributor Author

zimulala commented May 4, 2023

/test check-dev

@zimulala zimulala added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label May 4, 2023
@ti-chi-bot ti-chi-bot bot merged commit 10776b3 into pingcap:master May 4, 2023
@zimulala zimulala deleted the zimuxia/owner-1 branch May 4, 2023 02:44
@ti-chi-bot ti-chi-bot mentioned this pull request May 4, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #43514.

ti-chi-bot bot pushed a commit that referenced this pull request May 4, 2023
@ti-chi-bot
owner: add setting/getting the owner value info (#43353) (#43514)
43cfa0d 
close #43352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the functions of set/get the owner value
4 participants
@zimulala @ti-chi-bot @hawkingrei @tangenta