Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planbuilder: Keep with clause when build recursive cte #43362

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

elsa0520
Copy link
Contributor

Fix inline cte + recursive cte + with clause could not found table name

What problem does this PR solve?

Issue Number: close #43318

Problem Summary:

What is changed and how it works?

The with clause is removed incorrectly when plan builder build recursive cte.
Due to the original AST is modified. When the plan builder builds again (such as inline cte), there will be a problem that the table name cannot be found.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

v6.5 and later

Fix inline cte + recursive cte + with clause could not found table name
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 24, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • fixdb

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 24, 2023
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 24, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed status/LGT1 Indicates that a PR has LGTM 1. do-not-merge/needs-triage-completed labels Apr 24, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Apr 24, 2023
@elsa0520
Copy link
Contributor Author

/run-check_dev

@elsa0520
Copy link
Contributor Author

/test check-dev

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Apr 24, 2023
@fixdb
Copy link
Contributor

fixdb commented Apr 24, 2023

/retest

@winoros
Copy link
Member

winoros commented Apr 24, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 24, 2023

This pull request has been accepted and is ready to merge.

Commit hash: b2f4807

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 24, 2023
@winoros winoros merged commit eff3a8f into pingcap:master Apr 24, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #43371.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #43372.

@elsa0520
Copy link
Contributor Author

/cherry-pick release-6.5-20230425-v6.5.2

@ti-chi-bot
Copy link
Member

@elsa0520: new pull request created to branch release-6.5-20230425-v6.5.2: #43404.

In response to this:

/cherry-pick release-6.5-20230425-v6.5.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query with CTE failed to recognize tmp table
5 participants