Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: provide a option to wait for init stats to finish before providing service during startup #43381

Merged
merged 2 commits into from
Apr 26, 2023
Merged

*: provide a option to wait for init stats to finish before providing service during startup #43381

merged 2 commits into from
Apr 26, 2023

Conversation

xuyifangreeneyes
Copy link
Contributor

@xuyifangreeneyes xuyifangreeneyes commented Apr 25, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #43385 ref #42160

Problem Summary:

What is changed and how it works?

Introduce the configuration force-init-stats, which indicates whether to wait for init stats to finish before providing service during startup.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Add time.Sleep(30 * time.Second) at the beginning of init stats to simulate slow init stats. Start the tidb node with setting force-init-stats to true. The connection from mysql client is accepted after init stats is finished(after roughly 30 sec).

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@xuyifangreeneyes xuyifangreeneyes requested a review from a team as a code owner April 25, 2023 04:19
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 25, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-triage-completed needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-4.0 needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-linked-issue do-not-merge/needs-triage-completed labels Apr 25, 2023
@xuyifangreeneyes
Copy link
Contributor Author

/test unit-test

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 25, 2023
qw4990
qw4990 reviewed Apr 26, 2023
View reviewed changes
domain/domain.go Outdated
@@ -2176,6 +2176,7 @@ func (do *Domain) loadStatsWorker() {
} else {
logutil.BgLogger().Info("init stats info time", zap.Bool("lite", liteInitStats), zap.Duration("take time", time.Since(t)))
}
close(statsHandle.InitStatsDone)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to add this line to the above defer function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 26, 2023
@hawkingrei
Copy link
Member

/test all

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 26, 2023
@xuyifangreeneyes xuyifangreeneyes deleted the force-init-stats branch April 26, 2023 15:18
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 26, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #43444.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 26, 2023
@xuyifangreeneyes @ti-chi-bot
This is an automated cherry-pick of pingcap#43381
23369cb 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 26, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #43445.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 26, 2023
@xuyifangreeneyes @ti-chi-bot
This is an automated cherry-pick of pingcap#43381
6b39750 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 26, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-4.0: #43446.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 26, 2023
@xuyifangreeneyes @ti-chi-bot
This is an automated cherry-pick of pingcap#43381
35f2439 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 26, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #43447.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 26, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.0: #43448.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 26, 2023
@xuyifangreeneyes @ti-chi-bot
This is an automated cherry-pick of pingcap#43381
5c799a0 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 26, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #43449.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 26, 2023
@xuyifangreeneyes @ti-chi-bot
This is an automated cherry-pick of pingcap#43381
644ce1a 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 26, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #43450.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 26, 2023
@xuyifangreeneyes @ti-chi-bot
This is an automated cherry-pick of pingcap#43381
0e1398e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced May 4, 2023
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request May 4, 2023
@ti-chi-bot
*: provide a option to wait for init stats to finish before providing…
d207824 
… service during startup (#43381) (#43447)

ref #42160, close #43385
This was referenced May 11, 2023
Closed
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Dec 18, 2023
@ti-chi-bot
*: provide a option to wait for init stats to finish before providing…
10caef0 
… service during startup (#43381) (#43445)

ref #42160, close #43385
This was referenced Jan 3, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@qw4990 qw4990 qw4990 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

optimizer may make bad decisions due to pseudo stats during init stats
5 participants
@xuyifangreeneyes @hawkingrei @ti-chi-bot @qw4990 @winoros