Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disttask: Change rand choose TiDB to round selection TiDB to be an executor #43440

Merged
merged 6 commits into from
Apr 27, 2023
Merged

disttask: Change rand choose TiDB to round selection TiDB to be an executor #43440

merged 6 commits into from
Apr 27, 2023

Conversation

Benjamin2037
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #43439

Problem Summary:

What is changed and how it works?

Change the random choose one of TiDB node to one specific subtask to round robin choose one TiDB to make subtasks could be evenly run on all available TiDB nodes.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 26, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • wjhuang2016
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 26, 2023
@Benjamin2037
Copy link
Collaborator Author

/retest

@Benjamin2037
Copy link
Collaborator Author

/retest

@Benjamin2037 Benjamin2037 changed the title disttask: Change rand choose TiDB to round selection TiDB to be an executor. disttask: Change rand choose TiDB to round selection TiDB to be an executor(WIP) Apr 26, 2023
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels Apr 26, 2023
@Benjamin2037 Benjamin2037 changed the title disttask: Change rand choose TiDB to round selection TiDB to be an executor(WIP) disttask: Change rand choose TiDB to round selection TiDB to be an executor Apr 27, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 27, 2023
zimulala
zimulala approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 27, 2023
@Benjamin2037
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 27, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 1b19422

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 27, 2023
@ti-chi-bot ti-chi-bot bot merged commit d901924 into pingcap:master Apr 27, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 27, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #43474.

ti-chi-bot bot pushed a commit that referenced this pull request May 4, 2023
@ti-chi-bot
disttask: Change rand choose TiDB to round selection TiDB to be an ex…
33089aa 
…ecutor (#43440) (#43474)

close #43439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change random choose TiDB to round roubin choose TiDB to be available TiDB to run a subtask.
4 participants
@Benjamin2037 @ti-chi-bot @zimulala @wjhuang2016