Optimizer: do not simplify != NULL (#43434) #43442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
VelocityLight
added
cherry-pick-approved
|
/retest |
1 similar comment
|
/retest |
chrysan
approved these changes
Apr 27, 2023
qw4990
approved these changes
Apr 27, 2023
ti-chi-bot
bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: f7dc985
|
ti-chi-bot
bot
added
the
status/can-merge
VelocityLight
added
do-not-merge/cherry-pick-not-approved
cherry-pick-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #43434
Issue Number: Ref #43407
Problem Summary:
Predicate simplification merges x != constant1 with x in (list of values). Merge is not correct if constant is NULL.
TiDB follows mysql semantics where x != NULL is always false.
Solution
Do not apply the merge of <> and in list for x != NULL.
Tests
Unit tests
Side effects
None
Documentation
None
Release note