-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: wait schema change before rename table job is done (#43341) #43456
ddl: wait schema change before rename table job is done (#43341) #43456
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 669eae7
|
This is an automated cherry-pick of #43341
What problem does this PR solve?
Issue Number: close #43338
Problem Summary:
What is changed and how it works?
We split the renaming table job into two steps:
This is the requirement from TiCDC because
when the job state is updated to JobStateDone, before the new schema reloaded,
there may be DMLs that use the old schema.
the commit TS of the DMLs are greater than the job state updating TS.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.