Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: avoid too many warning logs after update schema version (#43416) #43619

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #43416

What problem does this PR solve?

Issue Number: close #43402

Problem Summary:
after log restore, there are many warning logs, see the issue.

What is changed and how it works?

Add a diffKey whose regenerateSchemaMap is true to trigger full load schemas.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    If modify the 64 + ... to 6 to trigger loadSchemaDiff, the log would print that as follows:
[2023/05/08 15:46:48.758 +08:00] [ERROR] [domain.go:249] ["failed to load schema diff"] [error="Meets a schema diff with RegenerateSchemaMap flag"] [errorVerbose="Meets a schema diff with RegenerateSchemaMap flag\ngithub.com/pingcap/tidb/domain.(*Domain).tryLoadSchemaDiffs\n\t/root/tidb/domain/domain.go:421\ngithub.com/pingcap/tidb/domain.(*Domain).loadInfoSchema\n\t/root/tidb/domain/domain.go:236\ngithub.com/pingcap/tidb/domain.(*Domain).Reload\n\t/root/tidb/domain/domain.go:556\ngithub.com/pingcap/tidb/domain.(*Domain).loadSchemaInLoop\n\t/root/tidb/domain/domain.go:862\ngithub.com/pingcap/tidb/domain.(*Domain).Init.func3\n\t/root/tidb/domain/domain.go:1181\ngithub.com/pingcap/tidb/util.(*WaitGroupEnhancedWrapper).Run.func1\n\t/root/tidb/util/wait_group_wrapper.go:96\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1598"] [stack="github.com/pingcap/tidb/domain.(*Domain).loadInfoSchema\n\t/root/tidb/domain/domain.go:249\ngithub.com/pingcap/tidb/domain.(*Domain).Reload\n\t/root/tidb/domain/domain.go:556\ngithub.com/pingcap/tidb/domain.(*Domain).loadSchemaInLoop\n\t/root/tidb/domain/domain.go:862\ngithub.com/pingcap/tidb/domain.(*Domain).Init.func3\n\t/root/tidb/domain/domain.go:1181\ngithub.com/pingcap/tidb/util.(*WaitGroupEnhancedWrapper).Run.func1\n\t/root/tidb/util/wait_group_wrapper.go:96"]
[2023/05/08 15:46:48.785 +08:00] [INFO] [domain.go:271] ["full load InfoSchema success"] [currentSchemaVersion=2908] [neededSchemaVersion=2914] ["start time"=29.410245ms]
[2023/05/08 15:46:48.787 +08:00] [INFO] [domain.go:586] ["full load and reset schema validator"]
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 8, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • Leavrth

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels May 8, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 8, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 8, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 8, 2023
@Leavrth
Copy link
Contributor

Leavrth commented May 8, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 8, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 55dd2c9

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 8, 2023
@Leavrth
Copy link
Contributor

Leavrth commented May 8, 2023

/retest

2 similar comments
@Leavrth
Copy link
Contributor

Leavrth commented May 8, 2023

/retest

@Leavrth
Copy link
Contributor

Leavrth commented May 8, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit 589d28b into pingcap:release-7.1 May 8, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants