Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor, types: format output #4372

Merged
merged 4 commits into from
Aug 30, 2017
Merged

executor, types: format output #4372

merged 4 commits into from
Aug 30, 2017

Conversation

lkk2003rty
Copy link
Contributor

@lkk2003rty lkk2003rty commented Aug 29, 2017 •
edited by zz-jason
Loading

fix #4074
fix #4299

@zz-jason zz-jason changed the title format output executor, types: format output Aug 29, 2017
zz-jason
zz-jason reviewed Aug 29, 2017
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added contribution This PR is from a community contributor. status/LGT1 Indicates that a PR has LGTM 1. labels Aug 29, 2017
@zz-jason
Copy link
Member

@breeswish PTAL

@shenli
Copy link
Member

shenli commented Aug 30, 2017

LGTM
@lkk2003rty Thanks!

@shenli shenli merged commit 271f0c0 into pingcap:master Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@shenli shenli shenli approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FieldType.CompactStr() Not Escaped SHOW CREATE TABLE not escaped
3 participants
@lkk2003rty @zz-jason @shenli