Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix cte may hang because register OOMAction repeatedly #43758

Merged
merged 9 commits into from
May 12, 2023
Merged

executor: fix cte may hang because register OOMAction repeatedly #43758

merged 9 commits into from
May 12, 2023

Conversation

guo-shaoge
Copy link
Collaborator

@guo-shaoge guo-shaoge commented May 12, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #43749 close #36896

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@guo-shaoge
executor: fix cte may hang because register OOMAction repeatedly
d4182df 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 12, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 12, 2023
@guo-shaoge
fix Close
17b64bb 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
fmt fmt
83517d8 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
fix storage
27be2ef 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
fix case
682ddfd 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
fix
f4fbbbd 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
fix err
48f811a 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
fix err
cd0220f 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
Merge branch 'fix_cte_oom_hang' of github.com:guo-shaoge/tidb into fi…
119517a 
…x_cte_oom_hang
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 12, 2023
@wuhuizuo
Copy link
Contributor

/retest

@wuhuizuo
Copy link
Contributor

/retest

CI should refresh share library by force, should not wait for serval minutes.

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels May 12, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 12, 2023
@hawkingrei
Copy link
Member

/test all

@guo-shaoge
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 12, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 119517a

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 12, 2023
@ti-chi-bot ti-chi-bot bot merged commit cd334c4 into pingcap:master May 12, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 12, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #43770.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 12, 2023
@guo-shaoge @ti-chi-bot
This is an automated cherry-pick of pingcap#43758
e05dc97 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 12, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #43771.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 12, 2023
@guo-shaoge @ti-chi-bot
This is an automated cherry-pick of pingcap#43758
392c2a8 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 12, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #43772.

@ti-chi-bot ti-chi-bot mentioned this pull request May 12, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #43773.

@ti-chi-bot ti-chi-bot mentioned this pull request May 12, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #43774.

@guo-shaoge guo-shaoge mentioned this pull request May 13, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request May 18, 2023
@ti-chi-bot
executor: fix cte may hang because register OOMAction repeatedly (#43758
cb98f2c 
) (#43774)

close #36896, close #43749
@guo-shaoge
Copy link
Collaborator Author

/run-cherry-picker

ti-chi-bot bot pushed a commit that referenced this pull request May 23, 2023
@ti-chi-bot
executor: fix cte may hang because register OOMAction repeatedly (#43758
3110690 
) (#43771)

close #36896, close #43749
ti-chi-bot bot pushed a commit that referenced this pull request May 23, 2023
@ti-chi-bot
executor: fix cte may hang because register OOMAction repeatedly (#43758
507a4ca 
) (#43773)

close #36896, close #43749
ti-chi-bot bot pushed a commit that referenced this pull request May 23, 2023
@ti-chi-bot
executor: fix cte may hang because register OOMAction repeatedly (#43758
833ba03 
) (#43772)

close #36896, close #43749
ti-chi-bot bot pushed a commit that referenced this pull request May 23, 2023
@ti-chi-bot
executor: fix cte may hang because register OOMAction repeatedly (#43758
fe24d1f 
) (#43770)

close #36896, close #43749
@XuHuaiyu XuHuaiyu mentioned this pull request Jun 7, 2023
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
6 participants
@guo-shaoge @wuhuizuo @hawkingrei @ti-chi-bot @XuHuaiyu @wshwsh12