Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: list the retryable errors for ingest mode | tidb-test=pr/2129 #43782

Merged
merged 7 commits into from
May 18, 2023
Merged

ddl: list the retryable errors for ingest mode | tidb-test=pr/2129 #43782

merged 7 commits into from
May 18, 2023

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented May 12, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #43814

Problem Summary:

What is changed and how it works?

  • Enumerate the retryable errors during adding index, and retry the execution only if necessary.
  • Unwrap the error "Cannot decode index value" to improve the MySQL compatibility.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 12, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Benjamin2037
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 12, 2023
@tangenta
Copy link
Contributor Author

/run_integration_mysql_test

@tangenta
Copy link
Contributor Author

/test ?

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 12, 2023

@tangenta: The following commands are available to trigger required jobs:

  • /test build
  • /test canary-scan-security
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/ghpr_build
  • pingcap/tidb/ghpr_check
  • pingcap/tidb/ghpr_check2
  • pingcap/tidb/ghpr_mysql_test
  • pingcap/tidb/ghpr_unit_test

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tangenta
Copy link
Contributor Author

/test all

@tangenta
Copy link
Contributor Author

/run-integration-mysql-test

@tangenta
Copy link
Contributor Author

/run-merged-integration-mysql-test

@purelind
Copy link
Contributor

/run-integration-common-test

@tangenta tangenta changed the title ddl: list the retryable errors for ingest mode ddl: list the retryable errors for ingest mode | tidb-test=pr/2129 May 15, 2023
@tangenta
Copy link
Contributor Author

/run-integration-common-test

@tangenta
Copy link
Contributor Author

/run-integration-common-test

1 similar comment
@purelind
Copy link
Contributor

/run-integration-common-test

@tangenta
Copy link
Contributor Author

/run-integration-common-test tidb-test=pr/2129

@tangenta
Copy link
Contributor Author

/run-mysql-test tidb-test=pr/2129

@tangenta
Copy link
Contributor Author

/run-integration-common-test tidb-test=pr/2129

@purelind
Copy link
Contributor

/test pull-integration-mysql-test

@tangenta
Copy link
Contributor Author

/test pull-integration-mysql-test

@tangenta
Copy link
Contributor Author

/run-integration-common-test tidb-test=pr/2129

@purelind
Copy link
Contributor

/test pull-integration-mysql-test

@tangenta
Copy link
Contributor Author

/retest

1 similar comment
@tangenta
Copy link
Contributor Author

/retest

Benjamin2037
Benjamin2037 approved these changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 17, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 18, 2023
@tangenta
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 18, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 0082ccb

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 18, 2023
@tangenta tangenta changed the title ddl: list the retryable errors for ingest mode | tidb-test=pr/2129 ddl: list the retryable errors for ingest mode May 18, 2023
@tangenta tangenta changed the title ddl: list the retryable errors for ingest mode ddl: list the retryable errors for ingest mode | tidb-test=pr/2129 May 18, 2023
@tangenta
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit f636e44 into pingcap:master May 18, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 18, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #43958.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 18, 2023
@tangenta @ti-chi-bot
This is an automated cherry-pick of pingcap#43782
601c89c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request May 25, 2023
@ti-chi-bot
ddl: list the retryable errors for ingest mode | tidb-test=pr/2142 (#…
bae2333 
…43782) (#43958)

close #43814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TiDB integration test failed in release 7.1
5 participants
@tangenta @purelind @ti-chi-bot @Benjamin2037 @wjhuang2016