-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Fixed double writing to correct hash/key partition during reorg #43891
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It's greate job to find this issue and fix it. LGTM. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ebd2207
|
/retest |
3 similar comments
/retest |
/retest |
/retest |
/test all |
/retest |
/test check_dev_2 |
@mjonss: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test check-dev2 |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #43892
Problem Summary:
The double writing during ADD/COALESCE PARTITION (for HASH/KEY partitioned tables) would use the old number of partitions, resulting in writing to the wrong partition, which may cause duplicate or lost rows.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.