Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: ebs tags refactoring (#44381) #44411

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #44381

What problem does this PR solve?

Issue Number: close #43934

Problem Summary:

What is changed and how it works?

This pr refactored to

  1. carry all tags of ebs volume to the snapshots as they are
  2. carry tags for snapshots to restored volume whose keys of tags are prefixed with "snapshot/"

Check List

Tests

  • Unit test

  • Integration test

  • Manual test (add detailed scripts or steps below)
    Verify the logic by EBS snapshot backup and restore, take one volume as example,
    original tags
    NzQRMB46e8
    snapshot for the volume
    IbzQ4OQfNM
    tags for restored volume
    img_v2_b33e957e-04ff-4fe2-a3b0-83ac5672cc5g

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 5, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 5, 2023
12 tasks
@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 5, 2023
@ti-chi-bot ti-chi-bot bot requested a review from aytrack June 5, 2023 09:41
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Jun 5, 2023
@ti-chi-bot ti-chi-bot bot requested a review from TszKitLo40 June 5, 2023 09:41
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 5, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 5, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Jun 5, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 5, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 7, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 7, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Jun 8, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 8, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 8, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 29, 2023
@BornChanger
Copy link
Contributor

/cherry-pick-invite @BornChanger

@ti-chi-bot
Copy link
Member Author

@BornChanger you're already a collaborator in repo ti-chi-bot/tidb

BornChanger and others added 2 commits June 30, 2023 22:52
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger BornChanger force-pushed the cherry-pick-44381-to-release-7.1 branch from 7a8ac14 to 09675dc Compare June 30, 2023 15:02
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 30, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 30, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-29 07:46:45.691017168 +0000 UTC m=+866571.092267616: ☑️ agreed by BornChanger.
  • 2023-06-30 15:23:12.536097822 +0000 UTC m=+99075.910675676: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot merged commit 36b6ba7 into pingcap:release-7.1 Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants