Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: retry for leader change error when GetTS #44478

Merged
merged 6 commits into from
Jun 12, 2023
Merged

lightning: retry for leader change error when GetTS #44478

merged 6 commits into from
Jun 12, 2023

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Jun 7, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #44263

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lance6716
lightning: retry for leader change error when GetTS
b827f28 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 7, 2023
@ti-chi-bot ti-chi-bot bot requested a review from mornyx June 7, 2023 07:15
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 7, 2023
lance6716 added 3 commits June 7, 2023 15:18
@lance6716
adjust log
20f98ea 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
adjust log
fd4c58f 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix bazel
37a8517 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/retest

@lance6716
Copy link
Contributor Author

/cc @D3Hunter @GMHDBJD @gozssky

@ti-chi-bot ti-chi-bot bot requested review from D3Hunter, GMHDBJD and sleepymole June 7, 2023 09:51
@lance6716
Copy link
Contributor Author

/run-integration-br-test

1 similar comment
@D3Hunter
Copy link
Contributor

D3Hunter commented Jun 7, 2023

/run-integration-br-test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 7, 2023

@D3Hunter: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter
Copy link
Contributor

D3Hunter commented Jun 7, 2023

/run-integration-br-test

@lance6716
Copy link
Contributor Author

/run-integration-br-test

GMHDBJD
GMHDBJD approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 9, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, GMHDBJD, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 12, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 12, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-09 08:19:55.68399942 +0000 UTC m=+72809.931921241: ☑️ agreed by GMHDBJD.
  • 2023-06-12 08:12:57.866714125 +0000 UTC m=+140127.321475423: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit d181d4e into pingcap:master Jun 12, 2023
@GMHDBJD GMHDBJD mentioned this pull request Jun 25, 2023
Merged
16 tasks
@lance6716 lance6716 mentioned this pull request Jul 12, 2023
Closed
lance6716 added a commit to lance6716/tidb that referenced this pull request Jul 12, 2023
@lance6716
lightning: retry for leader change error when GetTS (pingcap#44478)
e8df3d5 
close pingcap#44263
@lance6716 lance6716 mentioned this pull request Jul 12, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jul 13, 2023
@lance6716
lightning: retry for leader change error when GetTS (#44478) (#44856) (…
04f6570 
…#45330)

close #45301
This was referenced Jul 14, 2023
Open
Closed
ti-chi-bot bot pushed a commit that referenced this pull request Sep 4, 2023
@lance6716
lightning: retry for leader change error when GetTS (#44478) (#44856) (…
e2ba276 
…#46616)

close #46540
guoshouyan pushed a commit to guoshouyan/tidb that referenced this pull request Mar 5, 2024
@Tema @lance6716
lightning: retry for leader change error when GetTS (pingcap#44478) (p…
6e5334d 
…ingcap#44856) (pingcap#46616) (pingcap#1)

close pingcap#46540

Co-authored-by: lance6716 <lance6716@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

@mornyx mornyx Awaiting requested review from mornyx

@sleepymole sleepymole Awaiting requested review from sleepymole

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lightning should retry when PD leader switches
4 participants
@lance6716 @D3Hunter @hawkingrei @GMHDBJD