executor: set handle changed when col gets auto-updated #44566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zyguan <zhongyangguan@gmail.com>
ti-chi-bot
bot
added
release-note-none
Signed-off-by: zyguan <zhongyangguan@gmail.com>
ti-chi-bot
bot
added
needs-1-more-lgtm
Signed-off-by: zyguan <zhongyangguan@gmail.com>
cfzjywxk
reviewed
Jun 11, 2023
Signed-off-by: zyguan <zhongyangguan@gmail.com>
crazycs520
approved these changes
Jun 11, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, crazycs520 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
ti-chi-bot
pushed a commit
to ti-chi-bot/tidb
that referenced
this pull request
Jun 11, 2023
Signed-off-by: zyguan <zhongyangguan@gmail.com>
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
ti-chi-bot
pushed a commit
to ti-chi-bot/tidb
that referenced
this pull request
Jun 11, 2023
Signed-off-by: zyguan <zhongyangguan@gmail.com>
12 tasks
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tidb
that referenced
this pull request
Jun 11, 2023
Signed-off-by: zyguan <zhongyangguan@gmail.com>
12 tasks
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tidb
that referenced
this pull request
Jun 11, 2023
Signed-off-by: zyguan <zhongyangguan@gmail.com>
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
ti-chi-bot
pushed a commit
to ti-chi-bot/tidb
that referenced
this pull request
Jun 11, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #44565
Problem Summary: We didn't set
handleChangedproperly when a on-update-now column gets updated automatically and it's also a pk column, which leads to #44565 .What is changed and how it works?
Set
handleChangedproperly in that case.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.