Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makefile: always print log for importintotest #44676

Merged
merged 3 commits into from
Jun 15, 2023
Merged

makefile: always print log for importintotest #44676

merged 3 commits into from
Jun 15, 2023

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Jun 14, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #42930

Problem Summary:

What is changed and how it works?

  • on timeout, bazel won't print log sometimes, so we use --test_output=all to print log always

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 14, 2023
GMHDBJD
GMHDBJD approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 14, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 14, 2023
@D3Hunter
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jun 15, 2023
@D3Hunter D3Hunter changed the title makefile: enlarge importintotest test timeout [DNM]makefile: enlarge importintotest test timeout Jun 15, 2023
@D3Hunter D3Hunter changed the title [DNM]makefile: enlarge importintotest test timeout makefile: always print log for importintotest Jun 15, 2023
@D3Hunter
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2023
GMHDBJD
GMHDBJD approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 15, 2023

@purelind: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716, purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-14 11:21:31.37845432 +0000 UTC m=+171087.793058398: ☑️ agreed by GMHDBJD.
  • 2023-06-14 11:23:03.143849317 +0000 UTC m=+171179.558453398: ☑️ agreed by lance6716.
  • 2023-06-15 03:26:46.226398331 +0000 UTC m=+229002.641002403: ✖️🔁 reset by D3Hunter.
  • 2023-06-15 07:03:35.183638473 +0000 UTC m=+242011.598242546: ☑️ agreed by GMHDBJD.
  • 2023-06-15 07:47:11.002416205 +0000 UTC m=+244627.417020284: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit 079e497 into master Jun 15, 2023
@ti-chi-bot ti-chi-bot bot deleted the enlarge-test-timeout branch June 15, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@purelind purelind purelind approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@D3Hunter @lance6716 @purelind @GMHDBJD