Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

placement: supports survival preferences (#40613) #44701

Conversation

nolouch
Copy link
Member

@nolouch nolouch commented Jun 15, 2023

What problem does this PR solve?

Issue Number: close #38605

Problem Summary:

Is your feature request related to a problem? Please describe:
users hoped that the scale of high availability is controllable, not for the entire database. they want to distribute data across regions with specified tables. Such as:

image

Describe the feature you'd like:

Supports SQL Placement Policy Like :

ALTER PLACEMENT POLICY myplacementpolicy FOLLOWERS=5 SURVIVAL_PREFERENCES=["region", "zone", "host"]; 

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Documentation

  • Affects user behaviors
  • Contains syntax changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

placement: supports survival preferences

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 15, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 15, 2023
@lcwangchao
Copy link
Collaborator

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, rleungx, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-15 07:54:03.525089406 +0000 UTC m=+245039.939693481: ☑️ agreed by xhebox.
  • 2023-06-15 08:01:31.284633613 +0000 UTC m=+245487.699237686: ☑️ agreed by rleungx.

@HuSharp
Copy link
Contributor

HuSharp commented Jun 15, 2023

/test build

@HuSharp
Copy link
Contributor

HuSharp commented Jun 15, 2023

/test mysql-test

1 similar comment
@nolouch
Copy link
Member Author

nolouch commented Jun 15, 2023

/test mysql-test

@hawkingrei
Copy link
Member

/retest

1 similar comment
@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 413cbca into pingcap:release-6.5-20230425-v6.5.2 Jun 15, 2023
@nolouch nolouch deleted the release-6.5-20230425-v6.5.2 branch June 16, 2023 04:16
nolouch added a commit to nolouch/tidb that referenced this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants