Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import into: change max pool size to num-cpu #44749

Merged
merged 2 commits into from
Jun 18, 2023
Merged

import into: change max pool size to num-cpu #44749

merged 2 commits into from
Jun 18, 2023

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Jun 18, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #42930

Problem Summary:

What is changed and how it works?

  • change max pool size to num-cpu, so import be able to use all cpu resource, previously it's 10 independently on TiDB cpu count

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • after change cfg, import is 8(8c on local mac)
      nTF41gZrQL
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 18, 2023
lance6716
lance6716 approved these changes Jun 18, 2023
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, however we might need to check some resources should be left for other purposes

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 18, 2023
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jun 18, 2023 •
edited
Loading

changed to GOMAXPROCS, see https://stackoverflow.com/a/61866154 also

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 18, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-18 02:50:02.652953298 +0000 UTC m=+485999.067557376: ☑️ agreed by lance6716.
  • 2023-06-18 05:32:15.990462768 +0000 UTC m=+495732.405066847: ☑️ agreed by hawkingrei.

@hawkingrei
Copy link
Member

/hold

need more people to review.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2023
GMHDBJD
GMHDBJD approved these changes Jun 18, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [GMHDBJD,hawkingrei,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jun 18, 2023

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2023
@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jun 18, 2023

/merge

@ti-chi-bot ti-chi-bot bot merged commit 5bd56cb into master Jun 18, 2023
@ti-chi-bot ti-chi-bot bot deleted the import-pool-size branch June 18, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@D3Hunter @hawkingrei @GMHDBJD @lance6716