Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: add check resource group hint existence #45296

Merged
merged 2 commits into from
Jul 13, 2023
Merged

session: add check resource group hint existence #45296

merged 2 commits into from
Jul 13, 2023

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Jul 11, 2023

What problem does this PR solve?

Issue Number: close #45178

Problem Summary:

What is changed and how it works?

After setting resource group name from hint, check the group name's existence and directly fallback to the original group name if the hint name is invalid.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 11, 2023
@tiprow
Copy link

tiprow bot commented Jul 11, 2023

Hi @glorv. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jul 11, 2023
@hawkingrei
Copy link
Member

/retest

4 similar comments
@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/retest

nolouch
nolouch approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 13, 2023
CabinfeverB
CabinfeverB reviewed Jul 13, 2023
View reviewed changes
session/session.go Outdated
}
s.GetDomainInfoSchema()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why need this function

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, removed.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 13, 2023

@CabinfeverB: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-13 06:03:45.95993566 +0000 UTC m=+571117.730274372: ☑️ agreed by nolouch.
  • 2023-07-13 06:34:39.924554395 +0000 UTC m=+572971.694893111: ☑️ agreed by BornChanger.

@glorv
Copy link
Contributor Author

glorv commented Jul 13, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, CabinfeverB, glorv, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 13, 2023
@ti-chi-bot ti-chi-bot bot merged commit 63197ec into pingcap:master Jul 13, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 13, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #45347.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 13, 2023
@glorv @ti-chi-bot
This is an automated cherry-pick of pingcap#45296
a97bd59 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@glorv glorv deleted the fix-rg-hint branch July 13, 2023 07:13
ti-chi-bot bot pushed a commit that referenced this pull request Jul 13, 2023
@ti-chi-bot
session: add check resource group hint existence (#45296) (#45347)
503a6c5 
close #45178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BornChanger BornChanger BornChanger approved these changes

@CabinfeverB CabinfeverB CabinfeverB approved these changes

@nolouch nolouch nolouch approved these changes

@HuSharp HuSharp Awaiting requested review from HuSharp

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query execution failed with not exist ResourceGroup() hint
6 participants
@glorv @hawkingrei @ti-chi-bot @nolouch @CabinfeverB @BornChanger