Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dumpling: fix dumpling ignore file writer close error (#45374) #45407

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #45374

What problem does this PR solve?

Issue Number: close #45353

Problem Summary:

What is changed and how it works?

  1. fix the bug that multiQueriesChunk doesn't reset SQLRowIter.
  2. handle with writer close error and add some tests for it.

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • None

Documentation

  • None

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5-20230718-v6.5.2 labels Jul 18, 2023
lichunzhu
lichunzhu previously approved these changes Jul 18, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 18, 2023
@D3Hunter
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 18, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lichunzhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-18 07:04:03.343109533 +0000 UTC m=+1006735.113448245: ☑️ agreed by lichunzhu.
  • 2023-07-18 08:44:27.005471167 +0000 UTC m=+1012758.775809873: ☑️ agreed by D3Hunter.

@ti-chi-bot ti-chi-bot bot added the approved label Jul 18, 2023
@ti-chi-bot ti-chi-bot bot merged commit df49c13 into pingcap:release-6.5-20230718-v6.5.2 Jul 18, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5-20230718-v6.5.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants