Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sessionctx: set tiflash pipeline model to true by default #45516

Merged
merged 1 commit into from
Aug 1, 2023
Merged

sessionctx: set tiflash pipeline model to true by default #45516

merged 1 commit into from
Aug 1, 2023

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Jul 24, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #45618

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

TiFlash enables pipeline mode by default.

@SeaRise SeaRise requested a review from a team as a code owner July 24, 2023 05:31
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 24, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 24, 2023

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2023
@SeaRise SeaRise changed the title DMN: set tiflash pipeline model to true by default set tiflash pipeline model to true by default Jul 24, 2023
@tiprow
Copy link

tiprow bot commented Jul 24, 2023

Hi @SeaRise. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei hawkingrei changed the title set tiflash pipeline model to true by default sessionctx: set tiflash pipeline model to true by default Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023 •
edited
Loading

Codecov Report

Merging #45516 (0a83d3c) into master (f6be155) will increase coverage by 2.2292%.
Report is 79 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #45516        +/-   ##
================================================
+ Coverage   73.2506%   75.4799%   +2.2292%     
================================================
  Files          1264       1279        +15     
  Lines        389258     410207     +20949     
================================================
+ Hits         285134     309624     +24490     
+ Misses        85841      82746      -3095     
+ Partials      18283      17837       -446
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 75.4755% <ø> (+2.2249%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 87.8516% <ø> (+2.7852%) ⬆️
br 53.1363% <ø> (+1.0311%) ⬆️

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-linked-issue labels Jul 27, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Aug 1, 2023

/cc @windtalker @XuHuaiyu

@ti-chi-bot ti-chi-bot bot requested review from windtalker and XuHuaiyu August 1, 2023 03:16
@SeaRise
Copy link
Contributor Author

SeaRise commented Aug 1, 2023

/hold cancel

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 1, 2023
windtalker
windtalker approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 1, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [XuHuaiyu,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 1, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 1, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-01 07:16:26.578130504 +0000 UTC m=+169670.520479027: ☑️ agreed by XuHuaiyu.
  • 2023-08-01 07:22:34.326715286 +0000 UTC m=+170038.269063816: ☑️ agreed by windtalker.

@SeaRise
Copy link
Contributor Author

SeaRise commented Aug 1, 2023

/retest

@tiprow
Copy link

tiprow bot commented Aug 1, 2023

@SeaRise: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/test all

@SeaRise
Copy link
Contributor Author

SeaRise commented Aug 1, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Aug 1, 2023

@SeaRise: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Aug 1, 2023

/test check-dev2

@SeaRise
Copy link
Contributor Author

SeaRise commented Aug 1, 2023

/test check-dev

@tiprow
Copy link

tiprow bot commented Aug 1, 2023

@SeaRise: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Aug 1, 2023

@SeaRise: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 2d23240 into pingcap:master Aug 1, 2023
@SeaRise SeaRise deleted the set_tiflash_pipeline_model_by_default branch August 1, 2023 09:37
@SeaRise SeaRise mentioned this pull request Sep 6, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set tiflash pipeline model to true by default
4 participants
@SeaRise @hawkingrei @windtalker @XuHuaiyu