lightning: fix routes panic for csv data load (#45405) #45536
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #45405
What problem does this PR solve?
Issue Number: close #43284
Problem Summary:
Routes does not work for standard csv data.
tidb/br/pkg/lightning/mydump/loader.go
Lines 512 to 527 in c0e7057
It does map initialization for
s.dbSchemas
, then operate ons.tableSchemas
,s.viewSchemas
, ands.tableDatas
. However, the scope ofs.tableSchemas
does not cover the latter three ones, resulting in accessing invalid memory address or nil pointer dereference.What is changed and how it works?
For
s.tableSchemas
,s.viewSchemas
, ands.tableDatas
, initialize for each of them respectively, instead of initializing fors.dbSchemas
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.