-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: refine tikv/client-go log to print context information(such as conn id) as much as possible #45559
Conversation
…n id) as much as possible Signed-off-by: crazycs520 <crazycs520@gmail.com>
Hi @crazycs520. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: crazycs520 <crazycs520@gmail.com>
[LGTM Timeline notifier]Timeline:
|
/merge |
@cfzjywxk: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, ekexium, hawkingrei, MyonKeminta, you06 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #45559 +/- ##
================================================
+ Coverage 73.2002% 73.3840% +0.1838%
================================================
Files 1265 1268 +3
Lines 390134 391818 +1684
================================================
+ Hits 285579 287532 +1953
+ Misses 86238 86002 -236
+ Partials 18317 18284 -33
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
/test unit-test |
@crazycs520: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
…n id) as much as possible (pingcap#45559) Signed-off-by: crazycs520 <crazycs520@gmail.com>
* sessionctx: add sysvar to control exp feats of replica selector Signed-off-by: zyguan <zhongyangguan@gmail.com> * *: add rpc error stats and refine log (#52810) Signed-off-by: crazycs520 <crazycs520@gmail.com> * store: refine coprocessor error log (#52729) Signed-off-by: crazycs520 <crazycs520@gmail.com> * *: improve log about stale-read query (#52494) Signed-off-by: crazycs520 <crazycs520@gmail.com> * *: refine tikv/client-go log to print context information(such as conn id) as much as possible (#45559) Signed-off-by: crazycs520 <crazycs520@gmail.com> * add leader peer id log Signed-off-by: crazycs520 <crazycs520@gmail.com> * update log Signed-off-by: crazycs520 <crazycs520@gmail.com> * executor: fix issue that some query execution stats was omitted when execution was interrupted (#51787) close #51660 Signed-off-by: crazycs520 <crazycs520@gmail.com> * update go.mod Signed-off-by: crazycs520 <crazycs520@gmail.com> --------- Signed-off-by: zyguan <zhongyangguan@gmail.com> Signed-off-by: crazycs520 <crazycs520@gmail.com> Co-authored-by: zyguan <zhongyangguan@gmail.com>
…#53335) (pingcap#96) * *: add rpc error stats and refine log for diagnose (pingcap#53335) * sessionctx: add sysvar to control exp feats of replica selector Signed-off-by: zyguan <zhongyangguan@gmail.com> * *: add rpc error stats and refine log (pingcap#52810) Signed-off-by: crazycs520 <crazycs520@gmail.com> * store: refine coprocessor error log (pingcap#52729) Signed-off-by: crazycs520 <crazycs520@gmail.com> * *: improve log about stale-read query (pingcap#52494) Signed-off-by: crazycs520 <crazycs520@gmail.com> * *: refine tikv/client-go log to print context information(such as conn id) as much as possible (pingcap#45559) Signed-off-by: crazycs520 <crazycs520@gmail.com> * add leader peer id log Signed-off-by: crazycs520 <crazycs520@gmail.com> * update log Signed-off-by: crazycs520 <crazycs520@gmail.com> * executor: fix issue that some query execution stats was omitted when execution was interrupted (pingcap#51787) close pingcap#51660 Signed-off-by: crazycs520 <crazycs520@gmail.com> * update go.mod Signed-off-by: crazycs520 <crazycs520@gmail.com> --------- Signed-off-by: zyguan <zhongyangguan@gmail.com> Signed-off-by: crazycs520 <crazycs520@gmail.com> Co-authored-by: zyguan <zhongyangguan@gmail.com> * Update go.sum * Update go.mod --------- Signed-off-by: zyguan <zhongyangguan@gmail.com> Signed-off-by: crazycs520 <crazycs520@gmail.com> Co-authored-by: crazycs <crazycs520@gmail.com> Co-authored-by: zyguan <zhongyangguan@gmail.com>
What problem does this PR solve?
Issue Number: close #45558
Problem Summary: refine tikv/client-go log to print context information(such as conn id) as much as possible.
What is changed and how it works?
Use
Logger(ctx)
instead ofBgLogger
as much as possible.Since
Logger(ctx)
maybe contain other information such as connection id, which is good for debug.Here are some log before this PR:
In this PR, those logs will contain
conn
information:Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.