Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: support more join hints on parser (#45525) #45573

Merged
merged 9 commits into from
Jul 28, 2023
Merged

parser: support more join hints on parser (#45525) #45573

merged 9 commits into from
Jul 28, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #45525

What problem does this PR solve?

Issue Number: ref #45520

Problem Summary: planner: support more join hints on parser

What is changed and how it works?

planner: support more join hints on parser

Support these new hints below:

  1. no_hash_join, no_merge_join,
  2. index_join, no_index_join,
  3. index_hash_join, no_index_hash_join,
  4. index_merge_join, no_index_merge_join.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 26, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added component/parser epic/hint ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@da1e947). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #45573   +/-   ##
================================================
  Coverage               ?   73.6570%           
================================================
  Files                  ?       1080           
  Lines                  ?     346658           
  Branches               ?          0           
================================================
  Hits                   ?     255338           
  Misses                 ?      74899           
  Partials               ?      16421

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 26, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 26, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrysan, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 26, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 26, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-26 09:25:22.614019237 +0000 UTC m=+346465.208550211: ☑️ agreed by hawkingrei.
  • 2023-07-26 09:31:14.211381187 +0000 UTC m=+346816.805912175: ☑️ agreed by chrysan.

@qw4990
Copy link
Contributor

qw4990 commented Jul 26, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Jul 26, 2023

@qw4990: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor

qw4990 commented Jul 26, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Jul 26, 2023

@qw4990: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor

qw4990 commented Jul 26, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Jul 26, 2023

@qw4990: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor

qw4990 commented Jul 27, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Jul 27, 2023

@qw4990: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor

qw4990 commented Jul 27, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Jul 27, 2023

@qw4990: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/retest

@qw4990
Copy link
Contributor

qw4990 commented Jul 27, 2023

/rebuild

@qw4990
Copy link
Contributor

qw4990 commented Jul 27, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Jul 27, 2023

@qw4990: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2023
@qw4990
Copy link
Contributor

qw4990 commented Jul 27, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Jul 27, 2023

@qw4990: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor

qw4990 commented Jul 27, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Jul 27, 2023

@qw4990: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor

qw4990 commented Jul 28, 2023

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2023
@ti-chi-bot ti-chi-bot bot merged commit 65f6531 into pingcap:release-6.5 Jul 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrysan chrysan chrysan approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees

@qw4990 qw4990

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. component/parser epic/hint lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @qw4990 @hawkingrei @chrysan