Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Fix data race in TestSetLabelsConcurrentWithGetLabel #45579

Merged
merged 6 commits into from
Jul 26, 2023
Merged

*: Fix data race in TestSetLabelsConcurrentWithGetLabel #45579

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d7d2752
fix
gengliqi Jul 25, 2023
0edf6ee
update
gengliqi Jul 25, 2023
4235850
update test
gengliqi Jul 25, 2023
b24aa10
Merge remote-tracking branch 'upstream/master' into fix-label-race
gengliqi Jul 26, 2023
0869452
fix unstable test
gengliqi Jul 26, 2023
45b30f4
address comments
gengliqi Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/http_handler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1236,7 +1236,7 @@ func TestSetLabelsConcurrentWithGetLabel(t *testing.T) {
for i := 0; i < 100; i++ {
testUpdateLabels()
}
close(done)
done <- struct{}{}

// reset the global variable
config.GetGlobalConfig().Labels = map[string]string{}
gengliqi marked this conversation as resolved.
Show resolved Hide resolved
Expand Down