Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Remove tidb_enable_default_list_partition variable #45701

Merged

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Jul 31, 2023

What problem does this PR solve?

Issue Number: close #45700

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@mjonss mjonss requested a review from a team as a code owner July 31, 2023 16:03
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/invalid-title size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 31, 2023
@tiprow
Copy link

tiprow bot commented Jul 31, 2023

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #45701 (e82c5b1) into master (a53fd2d) will increase coverage by 0.3626%.
Report is 1 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45701        +/-   ##
================================================
+ Coverage   73.1995%   73.5621%   +0.3626%     
================================================
  Files          1265       1268         +3     
  Lines        390142     393023      +2881     
================================================
+ Hits         285582     289116      +3534     
+ Misses        86243      85646       -597     
+ Partials      18317      18261        -56     
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.5542% <100.0000%> (+0.3547%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0467% <ø> (+0.0108%) ⬆️
br 52.0158% <ø> (+0.0251%) ⬆️

@mjonss mjonss changed the title Remove tidb_enable_default_list_partition variable *: Remove tidb_enable_default_list_partition variable Jul 31, 2023
@mjonss
Copy link
Contributor Author

mjonss commented Jul 31, 2023

/retest

@tiprow
Copy link

tiprow bot commented Jul 31, 2023

@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 1, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 1, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 1, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 1, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-01 01:18:50.962225242 +0000 UTC m=+148214.904573779: ☑️ agreed by Defined2014.
  • 2023-08-01 01:53:13.903899833 +0000 UTC m=+150277.846248364: ☑️ agreed by tiancaiamao.

@hawkingrei
Copy link
Member

@bb7133 @XuHuaiyu @qw4990 PTAL

/hold

Our CI has a bug that al the PR will not merge because this pr is lack of the configure reviewer's approval.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2023
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, Defined2014, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,bb7133,tiancaiamao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hawkingrei
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2023
@ti-chi-bot ti-chi-bot bot merged commit 2e8de8d into pingcap:master Aug 1, 2023
7 of 9 checks passed
@mjonss mjonss deleted the remove-tidb_enable_default_list_partition branch August 1, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove tidb_enable_default_list_partition
5 participants