Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: extract region job's accessing data to an interface #45717

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Aug 1, 2023

What problem does this PR solve?

Issue Number: ref #45719

Problem Summary:

What is changed and how it works?

part of #45356

before this PR, region job holds an Engine structure which is the concept of local backend. In this PR an interface ingestData replaces Engine so we can introduce a new implementation. Compared with Engine which stores data in the disk, we can use a pure memory sorted slice of KV pairs to accomplish region job.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 1, 2023
@tiprow
Copy link

tiprow bot commented Aug 1, 2023

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #45717 (c503062) into master (2e8de8d) will increase coverage by 0.2585%.
Report is 14 commits behind head on master.
The diff coverage is 93.7500%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45717        +/-   ##
================================================
+ Coverage   73.2032%   73.4617%   +0.2585%     
================================================
  Files          1265       1278        +13     
  Lines        390125     398632      +8507     
================================================
+ Hits         285584     292842      +7258     
- Misses        86231      87246      +1015     
- Partials      18310      18544       +234     
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.4537% <93.7500%> (+0.2505%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0467% <ø> (+0.0108%) ⬆️
br 52.4576% <93.7500%> (+0.4564%) ⬆️

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 1, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [tangenta,wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 2, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 2, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-01 10:03:59.6472305 +0000 UTC m=+179723.589579027: ☑️ agreed by wjhuang2016.
  • 2023-08-02 03:17:19.706581162 +0000 UTC m=+241723.648929678: ☑️ agreed by tangenta.

@lance6716
Copy link
Contributor Author

/retest

@tiprow
Copy link

tiprow bot commented Aug 2, 2023

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 412fa13 into pingcap:master Aug 2, 2023
15 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants