Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: support concurrent write for S3 writer #45723
*: support concurrent write for S3 writer #45723
Changes from 2 commits
267fe94
132cb87
7c03dc1
814a854
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Check warning on line 510 in br/pkg/storage/azblob.go
Codecov / codecov/patch
br/pkg/storage/azblob.go#L510
Check warning on line 249 in br/pkg/storage/gcs.go
Codecov / codecov/patch
br/pkg/storage/gcs.go#L249
Check warning on line 126 in br/pkg/storage/hdfs.go
Codecov / codecov/patch
br/pkg/storage/hdfs.go#L126
Check warning on line 46 in br/pkg/storage/noop.go
Codecov / codecov/patch
br/pkg/storage/noop.go#L46
Check warning on line 925 in br/pkg/storage/s3.go
Codecov / codecov/patch
br/pkg/storage/s3.go#L923-L925
Check warning on line 930 in br/pkg/storage/s3.go
Codecov / codecov/patch
br/pkg/storage/s3.go#L929-L930
Check warning on line 935 in br/pkg/storage/s3.go
Codecov / codecov/patch
br/pkg/storage/s3.go#L932-L935
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will we need to expose the 8MB as a configuration in future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, we can use hardcode for now.
Check warning on line 966 in br/pkg/storage/s3.go
Codecov / codecov/patch
br/pkg/storage/s3.go#L939-L966
Check warning on line 968 in br/pkg/storage/s3.go
Codecov / codecov/patch
br/pkg/storage/s3.go#L968