br/lightning: add range properties codec and kv/stats reader #45796

tangenta · 2023-08-03T11:17:57Z

What problem does this PR solve?

Issue Number: ref #45719

Problem Summary:

What is changed and how it works?

Add kv reader and stats reader.
Add codec for range properties.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2023-08-03T11:18:24Z

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tangenta · 2023-08-03T11:22:20Z

/hold wait for #45724.

codecov · 2023-08-03T11:29:15Z

Codecov Report

Merging #45796 (3663f96) into master (de30804) will increase coverage by 0.0512%.
Report is 7 commits behind head on master.
The diff coverage is 41.7391%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #45796        +/-   ##
================================================
+ Coverage   73.3404%   73.3916%   +0.0512%     
================================================
  Files          1274       1280         +6     
  Lines        393217     394448      +1231     
================================================
+ Hits         288387     289492      +1105     
- Misses        86445      86522        +77     
- Partials      18385      18434        +49

Flag	Coverage Δ
integration	`78.1388% <ø> (?)`
unit	`73.3835% <41.7391%> (+0.0430%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`54.0444% <ø> (ø)`
parser	`85.0467% <ø> (+0.0108%)`	⬆️
br	`52.1111% <41.7391%> (+0.0675%)`	⬆️

…ader

br/pkg/lightning/backend/external/codec.go

lance6716 · 2023-08-04T08:10:20Z

br/pkg/lightning/backend/external/kv_reader.go

+
+func (r *kvReader) nextKV() (key, val []byte, err error) {
+	if r.byteReader.eof() {
+		return nil, nil, nil


can we return the error directly to caller?

Sure. Let me remove the eof flag.

lance6716 · 2023-08-04T08:17:08Z

br/pkg/lightning/backend/external/stat_reader.go

+	}
+	propLen := int(binary.BigEndian.Uint32(*lenBytes))
+	if cap(r.propBytes) < propLen {
+		r.propBytes = make([]byte, propLen)


r.propBytes is not used?

wjhuang2016 · 2023-08-04T08:35:25Z

br/pkg/lightning/backend/external/stat_reader.go

+	}
+	r.byteReader.reset()
+	lenBytes, err := r.byteReader.readNBytes(4)
+	if err != nil {


it may return EOF here.

should convert to UnexpectedEOF except for the first readNBytes

tangenta · 2023-08-04T09:00:01Z

/unhold

wjhuang2016 · 2023-08-04T09:09:53Z

br/pkg/lightning/backend/external/kv_reader.go

+// noEOF converts the EOF error to io.ErrUnexpectedEOF.
+func noEOF(err error) error {
+	if err == io.EOF {
+		return io.ErrUnexpectedEOF


The error is not traced

I don't think we can have more clues when this is reported(even if it is traced).

At least we can know the stack.

ywqzzy · 2023-08-07T06:07:45Z

br/pkg/lightning/backend/external/stat_reader.go

+	sr, err := openStoreReaderAndSeek(ctx, store, name, 0)
+	if err != nil {
+		return nil, err
+	}
+	br, err := newByteReader(ctx, sr, bufSize)
+	if err != nil {
+		return nil, err
+	}


Same with kv_reader.go: 30-34

initFileOffset is different. I think it is simple enough.

ywqzzy · 2023-08-07T06:15:18Z

br/pkg/lightning/backend/external/kv_reader.go

+	}, nil
+}
+
+func (r *kvReader) nextKV() (key, val []byte, err error) {


kvReader and statReader's only have different nextxxx function, can we merge the code into one? just pass a function into the next function.

var k, v next(func() { k, v = })

Merging them into one is a bad idea because one may mistakenly call nextProps() after nextKV(), which is nonsense.

…ader

lance6716 · 2023-08-07T09:51:21Z

/lgtm

ti-chi-bot · 2023-08-07T09:51:24Z

@lance6716: Your lgtm message is repeated, so it is ignored.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wjhuang2016 · 2023-08-07T10:01:57Z

/lgtm

ti-chi-bot · 2023-08-07T10:02:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [lance6716,wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-08-07T10:02:04Z

[LGTM Timeline notifier]

Timeline:

2023-08-07 03:45:57.72528423 +0000 UTC m=+675441.667632762: ☑️ agreed by lance6716.
2023-08-07 10:02:03.164446798 +0000 UTC m=+7400.798292206: ☑️ agreed by wjhuang2016.

tangenta added 11 commits August 1, 2023 19:00

br/lightning: add byte reader implementation

96d9c12

split long signature into multiple lines

0f649eb

update bazel

d41671e

move comment inside function

889ce5e

update bazel

f1a2981

address comments

9ca6df7

make new buffer every time when buffer space is insufficient

dd4c34f

uppdate bazel

eec8757

bring back reset()

384faec

add nil assignment in reset()

76af9e5

br/lightning: add range properties codec and kv/stats reader

d0f88c4

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 3, 2023

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023

ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2023

Merge remote-tracking branch 'upstream/master' into global-sort-kv-re…

af59d34

…ader

ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 4, 2023

update bazel

9a12dda

ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 4, 2023

lance6716 reviewed Aug 4, 2023

View reviewed changes

wjhuang2016 reviewed Aug 4, 2023

View reviewed changes

tangenta added 2 commits August 4, 2023 16:48

remove unused field and refine code

2766544

update bazel and mark eof to unexpected eof

0d36602

ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2023

fix typo

53a96b2

wjhuang2016 reviewed Aug 4, 2023

View reviewed changes

lance6716 approved these changes Aug 7, 2023

View reviewed changes

ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 7, 2023

ywqzzy reviewed Aug 7, 2023

View reviewed changes

ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2023

Merge remote-tracking branch 'upstream/master' into global-sort-kv-re…

24457bf

…ader

ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2023

wjhuang2016 approved these changes Aug 7, 2023

View reviewed changes

tangenta added 2 commits August 7, 2023 16:03

update bazel

15e9328

update bazel

3663f96

ti-chi-bot bot added the lgtm label Aug 7, 2023

ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 7, 2023

ti-chi-bot bot merged commit 7212a5f into pingcap:master Aug 7, 2023
10 of 13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

br/lightning: add range properties codec and kv/stats reader #45796

br/lightning: add range properties codec and kv/stats reader #45796

tangenta commented Aug 3, 2023

tiprow bot commented Aug 3, 2023

tangenta commented Aug 3, 2023

codecov bot commented Aug 3, 2023 •

edited

Loading

lance6716 Aug 4, 2023

tangenta Aug 4, 2023

lance6716 Aug 4, 2023

tangenta Aug 4, 2023

wjhuang2016 Aug 4, 2023

lance6716 Aug 4, 2023 •

edited

Loading

tangenta commented Aug 4, 2023

wjhuang2016 Aug 4, 2023

tangenta Aug 4, 2023

wjhuang2016 Aug 7, 2023

tangenta Aug 7, 2023

ywqzzy Aug 7, 2023

tangenta Aug 7, 2023

ywqzzy Aug 7, 2023

tangenta Aug 7, 2023

lance6716 commented Aug 7, 2023

ti-chi-bot bot commented Aug 7, 2023

wjhuang2016 commented Aug 7, 2023

ti-chi-bot bot commented Aug 7, 2023

ti-chi-bot bot commented Aug 7, 2023

br/lightning: add range properties codec and kv/stats reader #45796

br/lightning: add range properties codec and kv/stats reader #45796

Conversation

tangenta commented Aug 3, 2023

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

tiprow bot commented Aug 3, 2023

tangenta commented Aug 3, 2023

codecov bot commented Aug 3, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lance6716 Aug 4, 2023 • edited Loading

Choose a reason for hiding this comment

tangenta commented Aug 4, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lance6716 commented Aug 7, 2023

ti-chi-bot bot commented Aug 7, 2023

wjhuang2016 commented Aug 7, 2023

ti-chi-bot bot commented Aug 7, 2023

ti-chi-bot bot commented Aug 7, 2023

[LGTM Timeline notifier]

codecov bot commented Aug 3, 2023 •

edited

Loading

lance6716 Aug 4, 2023 •

edited

Loading