Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessiontest: split test into more new packges #45833

Merged
merged 7 commits into from
Aug 6, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 4, 2023

What problem does this PR solve?

Issue Number: close #44940

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-linked-issue needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 4, 2023
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2023
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #45833 (2d619f1) into master (61fc58c) will increase coverage by 0.0252%.
Report is 8 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45833        +/-   ##
================================================
+ Coverage   73.3597%   73.3849%   +0.0252%     
================================================
  Files          1272       1275         +3     
  Lines        393078     393860       +782     
================================================
+ Hits         288361     289034       +673     
- Misses        86347      86442        +95     
- Partials      18370      18384        +14     
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.3767% <ø> (+0.0170%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0359% <ø> (ø)
br 52.0655% <ø> (-0.0120%) ⬇️

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei changed the title sessiontest: split variable test sessiontest: split test into more new packges Aug 4, 2023
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/test all

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 5, 2023
@hawkingrei
Copy link
Member Author

/test all

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 6, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 6, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-05 15:24:52.542275715 +0000 UTC m=+544576.484624245: ☑️ agreed by xhebox.
  • 2023-08-06 07:41:53.015532557 +0000 UTC m=+603196.957881087: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit a626b05 into pingcap:master Aug 6, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splitting Test Directories to Increase Test Concurrency and Optimize Cache
3 participants