lightning: make OpLevelOptional suppress the error of DoChecksum (#45486) #45866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
release-note-none
12 tasks
ti-chi-bot
bot
added
size/XL
ti-chi-bot
added
the
cherry-pick-approved
ti-chi-bot
bot
added
size/M
|
/cc @lance6716 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #45866 +/- ##
================================================
Coverage ? 73.8819%
================================================
Files ? 1083
Lines ? 348935
Branches ? 0
================================================
Hits ? 257800
Misses ? 74733
Partials ? 16402 |
lance6716
reviewed
Aug 15, 2023
br/tests/lightning_routes/run.sh
Outdated
| @@ -4,12 +4,17 @@ | |||
|
|
|||
| set -eux | |||
|
|
|||
| echo "testing checksum-error..." | |||
| export GO_FAILPOINTS="github.com/pingcap/tidb/br/pkg/lightning/importer/checksum-error=1*return()" | |||
There was a problem hiding this comment.
Suggested change
| export GO_FAILPOINTS="github.com/pingcap/tidb/br/pkg/lightning/importer/checksum-error=1*return()" | |
| export GO_FAILPOINTS="github.com/pingcap/tidb/br/pkg/lightning/restore/checksum-error=1*return()" |
|
/cc @lance6716 |
lance6716
approved these changes
Aug 15, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GMHDBJD, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #45486
What problem does this PR solve?
Issue Number: close #45382
Problem Summary:
lightning still fail at checksum stage when set
checksum = "optional".What is changed and how it works?
Make
OpLevelOptionalsuppress the error ofDoChecksum.Since the needed integration test is quite simple, I added it into existing integration test
lightning_routes.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.