Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: reset lexer.identifierDot correctly when reusing parsers (#45903) #45907

Open
wants to merge 3 commits into
base: release-5.4
Choose a base branch
from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #45903

What problem does this PR solve?

Issue Number: close #45898

Problem Summary: parser: reset lexer.identifierDot correctly when reusing parsers

What is changed and how it works?

parser: reset lexer.identifierDot correctly when reusing parsers

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added component/parser ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 8, 2023
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Aug 8, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 8, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 8, 2023
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 8, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 8, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 8, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,tiancaiamao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 8, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-08 09:21:54.044471543 +0000 UTC m=+18078.593487516: ☑️ agreed by hawkingrei.
  • 2023-08-08 09:26:09.262179101 +0000 UTC m=+18333.811195087: ☑️ agreed by tiancaiamao.

@hawkingrei
Copy link
Member

/retest

@qw4990
Copy link
Contributor

qw4990 commented Aug 9, 2023

/test unit-test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 9, 2023

@qw4990: No presubmit jobs available for pingcap/tidb@release-5.4

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@tiprow
Copy link

tiprow bot commented Aug 9, 2023

@qw4990: No presubmit jobs available for pingcap/tidb@release-5.4

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor

qw4990 commented Aug 9, 2023

/re-unit-test

@qw4990 qw4990 added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Aug 9, 2023
@hawkingrei
Copy link
Member

/test all

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 9, 2023

@hawkingrei: No presubmit jobs available for pingcap/tidb@release-5.4

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@tiprow
Copy link

tiprow bot commented Aug 9, 2023

@hawkingrei: No presubmit jobs available for pingcap/tidb@release-5.4

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/run-unit-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. component/parser lgtm ok-to-test Indicates a PR is ready to be tested. priority/release-blocker This issue blocks a release. Please solve it ASAP. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants