Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: support no_index_join, no_index_hash_join, no_index_merge_join hints (#45633) #45912

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Aug 8, 2023

This is an automated cherry-pick of #45633

What problem does this PR solve?

Issue Number: ref #45520

Problem Summary: planner: support no_index_join, no_index_hash_join, no_index_merge_join hints

What is changed and how it works?

planner: support no_index_join, no_index_hash_join, no_index_merge_join hints

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Aug 8, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 8, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Aug 8, 2023
@tiprow
Copy link

tiprow bot commented Aug 8, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 8, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 8, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-08 08:58:12.930169112 +0000 UTC m=+16657.479185095: ☑️ agreed by hawkingrei.
  • 2023-08-08 08:59:18.200290634 +0000 UTC m=+16722.749306613: ☑️ agreed by AilinKid.

@qw4990
Copy link
Contributor Author

qw4990 commented Aug 9, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Aug 9, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@74abc22). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #45912   +/-   ##
================================================
  Coverage               ?   73.7011%           
================================================
  Files                  ?       1083           
  Lines                  ?     347376           
  Branches               ?          0           
================================================
  Hits                   ?     256020           
  Misses                 ?      74941           
  Partials               ?      16415           

@ti-chi-bot ti-chi-bot bot merged commit f028669 into pingcap:release-6.5 Aug 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants