-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: save NEXT_GLOBAL_ROW_ID as uint64 instead of int64 (#45614) #45943
base: release-6.1
Are you sure you want to change the base?
lightning: save NEXT_GLOBAL_ROW_ID as uint64 instead of int64 (#45614) #45943
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @lance6716 |
/retest |
2 similar comments
/retest |
/retest |
@ti-chi-bot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #45614
What problem does this PR solve?
Issue Number: close #45427
Problem Summary:
lightning wrongly use
int64
to saveNEXT_GLOBAL_ROW_ID
.pingcap/tiflow#9391 (comment)
What is changed and how it works?
https://github.com/pingcap/tidb/blob/f1b9da103166162944ae41dc0943c93c0b91923b/br/pkg/lightning/backend/tidb/tidb.go#L847C1-L852
nextID
's type is changed tostring
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.