ddl: Exchange partition rollback (#45877) #45979
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #45877
What problem does this PR solve?
Issue Number: close #45791, close #45920
Problem Summary:
The first schema change state adds a restriction to the non-partitioned table, so that it can only write (insert/update) rows that would fit into the partition to be exchanged with. But if something fails afterwards, this is never cleared.
What is changed and how it works?
Adding rollback, in case of user cancellation or failure during the DDL execution, after the first state change.
Check List
Tests
Manual test for upgrade scenario, revert the changes made to
ddl/ddl_worker.go
(which sets thediff
struct) and run the tests manually.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.