Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explaintest: use mysql-tester in explaintest #45995

Merged
merged 7 commits into from
Aug 15, 2023

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #45961

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 11, 2023
@tiprow
Copy link

tiprow bot commented Aug 11, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #45995 (4aa5974) into master (54fde48) will decrease coverage by 1.7606%.
Report is 38 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45995        +/-   ##
================================================
- Coverage   74.7783%   73.0177%   -1.7606%     
================================================
  Files          1293       1300         +7     
  Lines        397912     402728      +4816     
================================================
- Hits         297552     294063      -3489     
- Misses        80991      90222      +9231     
+ Partials      19369      18443       -926     
Flag Coverage Δ
integration 26.0303% <ø> (-20.4756%) ⬇️
unit 73.6952% <ø> (+0.3567%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0548% <ø> (+0.0054%) ⬆️
br 47.6414% <ø> (-17.0537%) ⬇️

@Defined2014 Defined2014 changed the title explaintest: use mysql-tester instead of main.go explaintest: use mysql-tester in explaintest Aug 11, 2023
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 11, 2023
@Defined2014
Copy link
Contributor Author

/test check-dev2

@hawkingrei
Copy link
Member

/ok-to-test

@@ -17,16 +17,13 @@ TIDB_TEST_STORE_NAME=$TIDB_TEST_STORE_NAME
TIKV_PATH=$TIKV_PATH
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bazel's sh_test can be used here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will do it later with bazel support.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 14, 2023
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-14 06:06:07.879269344 +0000 UTC m=+524732.428285328: ☑️ agreed by xhebox.
  • 2023-08-15 03:18:39.2267858 +0000 UTC m=+601083.775801787: ☑️ agreed by bb7133.

@bb7133 bb7133 added the require-LGT3 Indicates that the PR requires three LGTM. label Aug 15, 2023
Copy link
Member

@hawkingrei hawkingrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope to see Bazel Cache available here as soon as possible.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, hawkingrei, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bb7133,hawkingrei,xhebox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 0dea51c into pingcap:master Aug 15, 2023
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. require-LGT3 Indicates that the PR requires three LGTM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants