Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter: enable revive for expression #46029

Merged
merged 4 commits into from
Aug 14, 2023
Merged

linter: enable revive for expression #46029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ff32ae
linter: enable revive for expression
hawkingrei Aug 13, 2023
e40fd00
update
hawkingrei Aug 13, 2023
299b8fb
update
hawkingrei Aug 13, 2023
5e8bb3d
update
hawkingrei Aug 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build/nogo_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,6 +511,7 @@
"types/json_binary_functions.go": "types/json_binary_functions.go",
"types/json_binary_test.go": "types/json_binary_test.go",
"ddl/": "ddl",
"expression/builtin.go": "expression/builtin code",
"expression/builtin_cast.go": "expression/builtin_cast code",
"server/": "server/ code",
"distsql/": "distsql code",
Expand Down
41 changes: 20 additions & 21 deletions expression/builtin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func (b *baseBuiltinFunc) PbCode() tipb.ScalarFuncSig {
// metadata returns the metadata of a function.
// metadata means some functions contain extra inner fields which will not
// contain in `tipb.Expr.children` but must be pushed down to coprocessor
func (b *baseBuiltinFunc) metadata() proto.Message {
func (*baseBuiltinFunc) metadata() proto.Message {
// We will not use a field to store them because of only
// a few functions contain implicit parameters
return nil
Expand Down Expand Up @@ -244,67 +244,67 @@ func (b *baseBuiltinFunc) getArgs() []Expression {
return b.args
}

func (b *baseBuiltinFunc) vecEvalInt(input *chunk.Chunk, result *chunk.Column) error {
func (*baseBuiltinFunc) vecEvalInt(*chunk.Chunk, *chunk.Column) error {
return errors.Errorf("baseBuiltinFunc.vecEvalInt() should never be called, please contact the TiDB team for help")
}

func (b *baseBuiltinFunc) vecEvalReal(input *chunk.Chunk, result *chunk.Column) error {
func (*baseBuiltinFunc) vecEvalReal(*chunk.Chunk, *chunk.Column) error {
return errors.Errorf("baseBuiltinFunc.vecEvalReal() should never be called, please contact the TiDB team for help")
}

func (b *baseBuiltinFunc) vecEvalString(input *chunk.Chunk, result *chunk.Column) error {
func (*baseBuiltinFunc) vecEvalString(*chunk.Chunk, *chunk.Column) error {
return errors.Errorf("baseBuiltinFunc.vecEvalString() should never be called, please contact the TiDB team for help")
}

func (b *baseBuiltinFunc) vecEvalDecimal(input *chunk.Chunk, result *chunk.Column) error {
func (*baseBuiltinFunc) vecEvalDecimal(*chunk.Chunk, *chunk.Column) error {
return errors.Errorf("baseBuiltinFunc.vecEvalDecimal() should never be called, please contact the TiDB team for help")
}

func (b *baseBuiltinFunc) vecEvalTime(input *chunk.Chunk, result *chunk.Column) error {
func (*baseBuiltinFunc) vecEvalTime(*chunk.Chunk, *chunk.Column) error {
return errors.Errorf("baseBuiltinFunc.vecEvalTime() should never be called, please contact the TiDB team for help")
}

func (b *baseBuiltinFunc) vecEvalDuration(input *chunk.Chunk, result *chunk.Column) error {
func (*baseBuiltinFunc) vecEvalDuration(*chunk.Chunk, *chunk.Column) error {
return errors.Errorf("baseBuiltinFunc.vecEvalDuration() should never be called, please contact the TiDB team for help")
}

func (b *baseBuiltinFunc) vecEvalJSON(input *chunk.Chunk, result *chunk.Column) error {
func (*baseBuiltinFunc) vecEvalJSON(*chunk.Chunk, *chunk.Column) error {
return errors.Errorf("baseBuiltinFunc.vecEvalJSON() should never be called, please contact the TiDB team for help")
}

func (b *baseBuiltinFunc) evalInt(row chunk.Row) (int64, bool, error) {
func (*baseBuiltinFunc) evalInt(chunk.Row) (int64, bool, error) {
return 0, false, errors.Errorf("baseBuiltinFunc.evalInt() should never be called, please contact the TiDB team for help")
}

func (b *baseBuiltinFunc) evalReal(row chunk.Row) (float64, bool, error) {
func (*baseBuiltinFunc) evalReal(chunk.Row) (float64, bool, error) {
return 0, false, errors.Errorf("baseBuiltinFunc.evalReal() should never be called, please contact the TiDB team for help")
}

func (b *baseBuiltinFunc) evalString(row chunk.Row) (string, bool, error) {
func (*baseBuiltinFunc) evalString(chunk.Row) (string, bool, error) {
return "", false, errors.Errorf("baseBuiltinFunc.evalString() should never be called, please contact the TiDB team for help")
}

func (b *baseBuiltinFunc) evalDecimal(row chunk.Row) (*types.MyDecimal, bool, error) {
func (*baseBuiltinFunc) evalDecimal(chunk.Row) (*types.MyDecimal, bool, error) {
return nil, false, errors.Errorf("baseBuiltinFunc.evalDecimal() should never be called, please contact the TiDB team for help")
}

func (b *baseBuiltinFunc) evalTime(row chunk.Row) (types.Time, bool, error) {
func (*baseBuiltinFunc) evalTime(chunk.Row) (types.Time, bool, error) {
return types.ZeroTime, false, errors.Errorf("baseBuiltinFunc.evalTime() should never be called, please contact the TiDB team for help")
}

func (b *baseBuiltinFunc) evalDuration(row chunk.Row) (types.Duration, bool, error) {
func (*baseBuiltinFunc) evalDuration(chunk.Row) (types.Duration, bool, error) {
return types.Duration{}, false, errors.Errorf("baseBuiltinFunc.evalDuration() should never be called, please contact the TiDB team for help")
}

func (b *baseBuiltinFunc) evalJSON(row chunk.Row) (types.BinaryJSON, bool, error) {
func (*baseBuiltinFunc) evalJSON(chunk.Row) (types.BinaryJSON, bool, error) {
return types.BinaryJSON{}, false, errors.Errorf("baseBuiltinFunc.evalJSON() should never be called, please contact the TiDB team for help")
}

func (b *baseBuiltinFunc) vectorized() bool {
func (*baseBuiltinFunc) vectorized() bool {
return false
}

func (b *baseBuiltinFunc) supportReverseEval() bool {
func (*baseBuiltinFunc) supportReverseEval() bool {
return false
}

Expand All @@ -321,7 +321,7 @@ func (b *baseBuiltinFunc) isChildrenReversed() bool {
return b.childrenReversed
}

func (b *baseBuiltinFunc) reverseEval(sc *stmtctx.StatementContext, res types.Datum, rType types.RoundingType) (types.Datum, error) {
func (*baseBuiltinFunc) reverseEval(*stmtctx.StatementContext, types.Datum, types.RoundingType) (types.Datum, error) {
return types.Datum{}, errors.Errorf("baseBuiltinFunc.reverseEvalInt() should never be called, please contact the TiDB team for help")
}

Expand All @@ -339,8 +339,7 @@ func (b *baseBuiltinFunc) isChildrenVectorized() bool {
}

func (b *baseBuiltinFunc) getRetTp() *types.FieldType {
switch b.tp.EvalType() {
case types.ETString:
if b.tp.EvalType() == types.ETString {
if b.tp.GetFlen() >= mysql.MaxBlobWidth {
b.tp.SetType(mysql.TypeLongBlob)
} else if b.tp.GetFlen() >= 65536 {
Expand Down Expand Up @@ -386,7 +385,7 @@ func (b *baseBuiltinFunc) cloneFrom(from *baseBuiltinFunc) {
b.ctor = from.ctor
}

func (b *baseBuiltinFunc) Clone() builtinFunc {
func (*baseBuiltinFunc) Clone() builtinFunc {
panic("you should not call this method.")
}

Expand Down