Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: avoid possible infinite loop checking tikv gc and scheduling status #46078

Merged
merged 1 commit into from
Aug 17, 2023
Merged

br: avoid possible infinite loop checking tikv gc and scheduling status #46078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions br/pkg/task/backup_ebs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,13 +295,13 @@
} else {
log.Warn("failed to wait schedule, will retry later", zap.Error(err2))
}
continue
}

log.Info("all leader regions got, start checking hole", zap.Int("len", len(allRegions)))
} else {
log.Info("all leader regions got, start checking hole", zap.Int("len", len(allRegions)))

Check warning on line 299 in br/pkg/task/backup_ebs.go

View check run for this annotation

Codecov / codecov/patch

br/pkg/task/backup_ebs.go#L298-L299 

Added lines #L298 - L299 were not covered by tests

if !isRegionsHasHole(allRegions) {
return nil
if !isRegionsHasHole(allRegions) {
return nil
}
log.Info("Regions has hole, needs sleep and retry")

Check warning on line 304 in br/pkg/task/backup_ebs.go

View check run for this annotation

Codecov / codecov/patch

br/pkg/task/backup_ebs.go#L301-L304 

Added lines #L301 - L304 were not covered by tests
}
time.Sleep(backoffer.ExponentialBackoff())
}
Expand Down
Loading