Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disttask: fix run one step SubtaskExecutor twice #46106

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Aug 15, 2023

What problem does this PR solve?

Issue Number: close #46098

Problem Summary:
One scheduler read 2 steps subtask and run all of them.

What is changed and how it works?

Scheduler only read specific step subtasks.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 15, 2023
@tiprow
Copy link

tiprow bot commented Aug 15, 2023

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ywqzzy ywqzzy changed the title disttask: fix run one step subtaskexecutor twice disttask: fix run one step SubtaskExecutor twice Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #46106 (ed79d1b) into master (3846e80) will decrease coverage by 1.9530%.
Report is 15 commits behind head on master.
The diff coverage is 65.7894%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46106        +/-   ##
================================================
- Coverage   74.7667%   72.8138%   -1.9530%     
================================================
  Files          1292       1306        +14     
  Lines        398141     402035      +3894     
================================================
- Hits         297677     292737      -4940     
- Misses        81100      90818      +9718     
+ Partials      19364      18480       -884     
Flag Coverage Δ
integration 25.7510% <0.0000%> (-20.5120%) ⬇️
unit 73.5215% <73.5294%> (+0.1694%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0765% <ø> (+0.0108%) ⬆️
br 47.6429% <ø> (-16.8696%) ⬇️

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 15, 2023
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Aug 15, 2023

/retest

1 similar comment
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Aug 16, 2023

/retest

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Aug 16, 2023

/cc @GMHDBJD

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 17, 2023
@hawkingrei
Copy link
Member

/test all

@hawkingrei
Copy link
Member

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-17 04:01:31.070609777 +0000 UTC m=+776455.619625763: ☑️ agreed by zimulala.
  • 2023-08-17 04:40:10.460964497 +0000 UTC m=+778775.009980484: ☑️ agreed by hawkingrei.

@tiprow
Copy link

tiprow bot commented Aug 17, 2023

@ywqzzy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test ed79d1b link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 24122b5 into pingcap:master Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unstable test TestFrameworkDeleteDomain
3 participants