Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: Fix different behaviors with MySQL when comparing datetime column with numeric constant | tidb-test=pr/2198 #46129

Merged
merged 4 commits into from
Aug 16, 2023
Merged

expression: Fix different behaviors with MySQL when comparing datetime column with numeric constant | tidb-test=pr/2198 #46129

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5e5188
Just comments change
yibin87 Aug 16, 2023
cf453fc
Submit actual cherry pick changes
yibin87 Aug 16, 2023
63d6518
Revert executor_test changes
yibin87 Aug 16, 2023
ca7fd94
Move unit test to planner
yibin87 Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion expression/builtin_compare.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1597,7 +1597,7 @@ func allowCmpArgsRefining4PlanCache(ctx sessionctx.Context, args []Expression) (
return false
}

// refineArgs will rewrite the arguments if the compare expression is `int column <cmp> non-int constant` or
// refineArg will rewrite the arguments if the compare expression is `int column <cmp> non-int constant` or
// `non-int constant <cmp> int column`. E.g., `a < 1.1` will be rewritten to `a < 2`. It also handles comparing year type
// with int constant if the int constant falls into a sensible year representation.
// This refine operation depends on the values of these args, but these values can change when using plan-cache.
Expand Down