Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: Update ServerVersion to 8.0.11 #46155

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Aug 16, 2023

This reverts commit a55d196.

What problem does this PR solve?

Issue Number: ref #7968

Problem Summary:

#42560 was reverted in #44744 as we decided to wait until #45650 was merged, and that's now the case.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

The MySQL version number reported by TiDB was updated to 8.0.11

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2023
@tiprow
Copy link

tiprow bot commented Aug 16, 2023

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #46155 (6c34193) into master (2af4b4d) will decrease coverage by 0.2645%.
Report is 79 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46155        +/-   ##
================================================
- Coverage   74.7646%   74.5002%   -0.2645%     
================================================
  Files          1296       1318        +22     
  Lines        398623     418615     +19992     
================================================
+ Hits         298029     311869     +13840     
- Misses        81213      88319      +7106     
+ Partials      19381      18427       -954     
Flag Coverage Δ
integration 27.3369% <ø> (-18.9287%) ⬇️
unit 75.1710% <ø> (+1.8193%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.2612% <ø> (+0.1955%) ⬆️
br 48.5505% <ø> (-15.9951%) ⬇️

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 21, 2023
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 22, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, mjonss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 24, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 24, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-22 07:46:25.526010327 +0000 UTC m=+1221950.075026314: ☑️ agreed by bb7133.
  • 2023-08-24 09:22:33.41903788 +0000 UTC m=+1400517.968053852: ☑️ agreed by mjonss.

@dveeden
Copy link
Contributor Author

dveeden commented Aug 24, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit 80441df into pingcap:master Aug 24, 2023
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants