-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add MVCC version ratio to slow log metrics (#44897) #46205
*: add MVCC version ratio to slow log metrics (#44897) #46205
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Jack Yu <jackysp@gmail.com>
/run-monitor-test |
@qiffang it doesn't work anymore, PTAL. |
/rebuild |
@hawkingrei why is the building failed, could you please take a look? Thx! |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It is a CI timeout. the solution is to rerun it. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #46205 +/- ##
================================================
Coverage ? 73.7503%
================================================
Files ? 1084
Lines ? 348409
Branches ? 0
================================================
Hits ? 256953
Misses ? 75015
Partials ? 16441 |
/merge |
@jackysp: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, jackysp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #44897
What problem does this PR solve?
Issue Number: close #44896
Problem Summary:
Add MVCC version ratio to slow log metrics.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.