Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: enable stats LFU cache #46246

Merged
merged 22 commits into from
Aug 22, 2023
Merged

executor: enable stats LFU cache #46246

merged 22 commits into from
Aug 22, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 19, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #46158

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 19, 2023
@codecov
Copy link

codecov bot commented Aug 19, 2023 •
edited
Loading

Codecov Report

Merging #46246 (1406a20) into master (7e476a5) will decrease coverage by 0.6686%.
Report is 3 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #46246        +/-   ##
================================================
- Coverage   73.3517%   72.6831%   -0.6686%     
================================================
  Files          1284       1305        +21     
  Lines        393256     399483      +6227     
================================================
+ Hits         288460     290357      +1897     
- Misses        86433      90692      +4259     
- Partials      18363      18434        +71
Flag Coverage Δ
integration 25.7217% <20.0000%> (?)
unit 73.3586% <100.0000%> (+0.0069%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0667% <ø> (ø)
br 47.8634% <ø> (-4.3768%) ⬇️

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 19, 2023
@hawkingrei
Copy link
Member Author

/test all

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-linked-issue labels Aug 19, 2023
@hawkingrei hawkingrei requested a review from qw4990 August 22, 2023 06:12
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
executor: enable stats LFU cache
31be556 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
executor: enable stats LFU cache
65f590c 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
executor: enable stats LFU cache
57e184c 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
executor: enable stats LFU cache
6f04444 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
executor: enable stats LFU cache
e7b3d87 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
executor: enable stats LFU cache
c166977 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
executor: enable stats LFU cache
6358a97 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: avoid sort
46987b0 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: avoid sort
65a2ba3 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: avoid sort
71918a9 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: avoid sort
f50fbc9 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: avoid sort
0c1ee43 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: avoid sort
e10feae 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: avoid sort
b1083f5 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
83875ce 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
8f22795 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
6913d3e 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
be90a24 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
14903f0 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
da90733 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
646d0e8 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 22, 2023
@hawkingrei
update
1406a20 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hi-rustin, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hi-rustin,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 22, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-22 08:38:34.339592144 +0000 UTC m=+1225078.888608115: ☑️ agreed by hi-rustin.
  • 2023-08-22 11:03:35.433484438 +0000 UTC m=+1233779.982500410: ☑️ agreed by time-and-fate.

@ti-chi-bot ti-chi-bot bot merged commit 29b9448 into pingcap:master Aug 22, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
approved component/statistics lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hawkingrei @time-and-fate @Rustin170506 @qw4990