Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/backup: fix test case br_autoid for the previous cherry-pick #46257

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #46093

Problem Summary:

What is changed and how it works?

In the previous cherry-pick #46217
I didn't notice the subtle difference between master and v6.5 branch.

Before this PR:
91f6752#diff-e611f02c279107dbfa433418c809e99569c0b24c2ea92cc7aef9f7f41fbcc3b9L581

old version use

idAlloc.NextGlobalAutoID()

and master use

rowID + 1

The semantic is the same, but the tiny code struct change make the previous cherry-pick introduce a bug and break CI.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Aug 21, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 21, 2023
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Aug 21, 2023
@tiprow
Copy link

tiprow bot commented Aug 21, 2023

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 21, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, Defined2014

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3pointer,Defined2014]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 21, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 21, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-21 02:39:26.017461579 +0000 UTC m=+1117130.566477550: ☑️ agreed by Defined2014.
  • 2023-08-21 02:41:44.745811552 +0000 UTC m=+1117269.294827538: ☑️ agreed by 3pointer.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@7de3979). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #46257   +/-   ##
================================================
  Coverage               ?   73.6581%           
================================================
  Files                  ?       1084           
  Lines                  ?     348081           
  Branches               ?          0           
================================================
  Hits                   ?     256390           
  Misses                 ?      75232           
  Partials               ?      16459           

@ti-chi-bot ti-chi-bot bot merged commit 8040e28 into pingcap:release-6.5 Aug 21, 2023
3 checks passed
@tiancaiamao tiancaiamao deleted the ci-release-6.5 branch August 21, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants