-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/backup: fix test case br_autoid for the previous cherry-pick #46257
Conversation
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, Defined2014 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #46257 +/- ##
================================================
Coverage ? 73.6581%
================================================
Files ? 1084
Lines ? 348081
Branches ? 0
================================================
Hits ? 256390
Misses ? 75232
Partials ? 16459 |
What problem does this PR solve?
Issue Number: ref #46093
Problem Summary:
What is changed and how it works?
In the previous cherry-pick #46217
I didn't notice the subtle difference between master and v6.5 branch.
Before this PR:
91f6752#diff-e611f02c279107dbfa433418c809e99569c0b24c2ea92cc7aef9f7f41fbcc3b9L581
old version use
and master use
The semantic is the same, but the tiny code struct change make the previous cherry-pick introduce a bug and break CI.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.