-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: reuse dupDetector to implement in-memory ingest data #46270
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
Hi @lance6716. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46270 +/- ##
================================================
- Coverage 73.3765% 72.6768% -0.6997%
================================================
Files 1285 1305 +20
Lines 394535 399581 +5046
================================================
+ Hits 289496 290403 +907
- Misses 86609 90736 +4127
- Partials 18430 18442 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #45719
Problem Summary:
What is changed and how it works?
to reuse local backend's logic, we need to let external engine implement IngestData interface. We can simple do it by loading KV pairs from external engine into memory. And to implement the duplicate detection feature, I extract
DupDetector
to let local engine and external engine use same code.Check List
Tests
master
this branch
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.