-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix data race in the ReuseChunkPool #46283
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46283 +/- ##
================================================
- Coverage 73.3694% 72.7002% -0.6692%
================================================
Files 1285 1306 +21
Lines 394832 401026 +6194
================================================
+ Hits 289686 291547 +1861
- Misses 86684 90957 +4273
- Partials 18462 18522 +60
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@cfzjywxk: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@qw4990: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
From the calling stack, you can infer that the same session is used by different goroutine, that's the root cause of the data race. |
/approve there is no variable change in this PR, LGTM |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, easonn7, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tidb/ddl/ingest/integration_test.go Lines 44 to 48 in 9411e82
Return this session for several goroutines to use is unsafe. |
/hold |
/hold |
What problem does this PR solve?
Issue Number: close #46282
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.