Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix the duplicate entry error when using BR to restore a NONCLUSTERED AUTO_ID_CACHE=1 table (#46127) #46333

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #46127

What problem does this PR solve?

Issue Number: close #46093

Problem Summary:

What is changed and how it works?

For a NONCLUSTERED table with AUTO_ID_CACHE=1, like the case in #46093,
there are both auto_increment_id and _tidb_rowid.

The model.TableInfo only get one field AutoIncID, the information is not enough to recover the table correctly.
So a AutoIncIDExtra field is added for that case. We can record _tidb_rowid in AutoIncIDExtra and recover the _tidb_rowid from it.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Test the case follow the steps in #46093 manually.


I'm trying to add some test but find it difficult to do that in a unit test.
For example, I tried to add it in the tests/realtikvtest/brietest but found that it does not start the server layer so the auto id service does not run and I can't test the AUTO_ID_CACHE=1
I tried to add it in the server/tests where a server is started, but it use unistore and br recover table ... can not run with unistore.

 func TestIssue46093(t *testing.T) {
        ts := createTidbTestSuite(t)

        ts.RunTestsOnNewDB(t, nil, "br", func(dbt *testkit.DBTestKit) {
                dbt.MustExec("drop table if exists t")
                dbt.MustExec("create table t (a int primary key nonclustered auto_increment, b int) auto_id_cache = 1;")
                dbt.MustExec("insert into t (b) values (1), (2), (3);")
                rows := dbt.MustQuery("show table t next_row_id;")
                ts.CheckRows(t, rows, "br t _tidb_rowid 30001 _TIDB_ROWID",
                        "br t _tidb_rowid 4 AUTO_INCREMENT")
                dbt.MustExec("backup table t to 'local:///tmp/br';")
                dbt.MustExec("drop table t;")
                dbt.MustExec("restore table t from 'local:///tmp/br';")
                rows = dbt.MustQuery("show table t next_row_id;")
                ts.CheckRows(t, rows, "1 4001")
                dbt.MustExec("insert into t (b) values (4), (5), (6);")
                dbt.MustExec("insert into t (b) values (7), (8), (9);")
                rows = dbt.MustQuery("select * from t;")
                ts.CheckRows(t, rows, "1 1", "2 2", "3 3", "4004 7", "4005 8", "4006 9")
        })
}
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 23, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign leavrth for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 23, 2023

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 81cf349 link true /test check-dev2
idc-jenkins-ci-tidb/unit-test 81cf349 link true /test unit-test
idc-jenkins-ci-tidb/build 81cf349 link true /test build
idc-jenkins-ci-tidb/check_dev 81cf349 link true /test check-dev
idc-jenkins-ci-tidb/mysql-test 81cf349 link true /test mysql-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jackysp
Copy link
Member

jackysp commented Aug 23, 2023

wrong branch

@jackysp jackysp closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.4 affects-6.5 affects-7.0 affects-7.1 affects-7.2 affects-7.3 do-not-merge/cherry-pick-not-approved ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants